Fix: Avoid object mutation in skill manager and expert resolution#12
Merged
Fix: Avoid object mutation in skill manager and expert resolution#12
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Merged
This was referenced Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSkillManagersresolveExpertToRun, move expert caching tosetupExpertsTest plan
Note
Eliminates object mutation in skill setup and expert resolution, moving caching to setupExperts and returning copied/converted structures.
packages/runtime/src/resolve-expert-to-run.ts):experts; return a converted expert viatoRuntimeExpert.nameformcpStdioSkill/mcpSseSkill/interactiveSkill.packages/runtime/src/setup-experts.ts):setting.experts; add resolvedexpertKeyand its delegates to the localexpertsmap.packages/runtime/src/skill-manager/helpers.ts):Written by Cursor Bugbot for commit 4c233b8. This will update automatically on new commits. Configure here.